DLL Injection Problems

[lanman92]

I've had a DLL that I inject into WoW that worked for about a week. It just recently started acting up. It almost seems like my DLL_PROCESS_ATTACH and detach got mixed up. No clue what I'm doing wrong. I switched the files over to another project and it worked fine for a while. Then it bitched again. Has anyone else observed this and/or fixed it?

[SKU]

Totally don't post code.

[lanman92]

It's not a code problem. It has to be the compiler or something. It works fine after I move it to a new project. I'll post code anyway.

BOOL APIENTRY DllMain( HMODULE hModule,
                       DWORD  ul_reason_for_call,
                       LPVOID lpReserved
                     )
{
    if(ul_reason_for_call == DLL_PROCESS_ATTACH)
    {
        DisableThreadLibraryCalls(hModule);
        CreateThread(0, 0, main, 0, 0, 0);
    }
    return TRUE;
}

main just detours sendpacket and initializes some class pointers(player and movementfields...).

EDIT: Also, WoW is throwing a access violation error whenever I close. I'll post back more on the error in a sec.

[lanman92]

After commenting out my code... I have it throwing an access violation, 0x00000 trying to access 0x0000000. No clue why this is happenening. Here's what I have for code.

void __cdecl sendpacket(CDataStore* packet)
{
     oSendPacket(packet);
}

[Powerking89670]

Originally Posted by lanman92

After commenting out my code... I have it throwing an access violation, 0x00000 trying to access 0x0000000. No clue why this is happenening. Here's what I have for code.

void __cdecl sendpacket(CDataStore* packet)
{
     oSendPacket(packet);
}

If that is throwing an access violation at 0x00000000, it's indicative of your packet variable being null at runtime, add a check to see if it's null before you try to use it in the oSendPacket function or try to find out why it's null.

If it is a null pointer issue this would fix it :

void __cdecl sendpacket(CDataStore* packet)
{
     if(packet != 0)
     {
     oSendPacket(packet);
     }
}

The reason it throws an access violation is because that address is most definitely not in the address space of the actual application (even with the pseudo addresses windows creates for each application so we don't need to deal with huge adresses constantly) and when you try to modify it, it will flip out.

If you say it happens when you close WoW, it's probably got something to do with the fact that the WoW buffer of packets is empty, and you're trying to grab one more than what exists.

Just my thoughts on it